test: remove unused variables on async hook test#32630
Closed
julianduque wants to merge 1 commit intonodejs:masterfrom
Closed
test: remove unused variables on async hook test#32630julianduque wants to merge 1 commit intonodejs:masterfrom
julianduque wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
approved these changes
Apr 3, 2020
cjihrig
approved these changes
Apr 3, 2020
jvelezpo
approved these changes
Apr 3, 2020
targos
approved these changes
Apr 3, 2020
tniessen
approved these changes
Apr 3, 2020
jasnell
approved these changes
Apr 3, 2020
lpinca
approved these changes
Apr 3, 2020
This commit remove the `id` and `type` arguments from the mustCall function on init.
julianduque
force-pushed
the
julianduque/remove-unused-variables-ah-test
branch
from
ad1b8b2 to
652a521
Compare
addaleax
added
the
author ready
Collaborator
Collaborator
Collaborator
Member
|
Landed in 056e687 |
addaleax
pushed a commit
that referenced
this pull request
Apr 6, 2020
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: #32630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: #32630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: #32630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
This commit remove the `id` and `type` arguments from the mustCall function on init. PR-URL: #32630 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
idandtypearguments from the mustCallfunction on init.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes